fix: replace rounded-circle with rounded on logo in admin pages#369
Open
Dipro-cyber wants to merge 1 commit into
Open
fix: replace rounded-circle with rounded on logo in admin pages#369Dipro-cyber wants to merge 1 commit into
Dipro-cyber wants to merge 1 commit into
Conversation
The CollectOSS logo was being cropped by Bootstrap's rounded-circle class which forces a circular mask on the rectangular logo image. Replaced with rounded class which softly rounds the corners without cropping the logo. Fixes chaoss#302 Signed-off-by: Diptesh Roy <droy88333@gmail.com>
Contributor
Author
|
@MoralCode sir can you pls check this? |
Contributor
|
Thanks for this change, looks like a super clean PR. I'm working on getting some of the large PRs that have been open for a while tested and merged so i can release v1.1 RC1 this week but once most of that has gone through, I can give this a quick run and merge it to potentially land in either 1.1 or 1.2 |
Contributor
Author
Sure sir. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced
rounded-circlewithroundedin both:collectoss/templates/admin-dashboard.j2collectoss/templates/settings.j2This preserves a subtle rounded corner without cropping the logo.
This PR fixes #302
Notes for Reviewers
Two one-word changes in template files. No logic changes.
Signed commits