Skip to content

System: Fix Behat scenario 'Enter to public password-protected course' - refs GH#1678 #4497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BorjaSanchezBeezNest wants to merge 14 commits into
base: 1.11.x
Choose a base branch
from
Open

System: Fix Behat scenario 'Enter to public password-protected course' - refs GH#1678 #4497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
226dce1
System: Fix Behat scenario 'Enter to public password-protected course…
BorjaSanchezBeezNest Dec 14, 2022
d2e2aa1
System: Upgrade chromedriver-version to '108.0.5359.71'
BorjaSanchezBeezNest Jan 12, 2023
7c31597
System: Change selenium screen resolution
BorjaSanchezBeezNest Jan 12, 2023
23b0dde
System: Change field to find
BorjaSanchezBeezNest Jan 12, 2023
45d9c1f
System: Change field to find
BorjaSanchezBeezNest Jan 12, 2023
66d6ca2
System: Change field to find
BorjaSanchezBeezNest Jan 12, 2023
20bf8b6
System: Change field to find
BorjaSanchezBeezNest Jan 12, 2023
5677e51
System: Change field to find
BorjaSanchezBeezNest Jan 12, 2023
a892a22
System: Change field to find
BorjaSanchezBeezNest Jan 12, 2023
78badcf
System: Change field to find
BorjaSanchezBeezNest Jan 12, 2023
b7b99ca
System: Change field to find
BorjaSanchezBeezNest Jan 12, 2023
817d5e8
System: Change field to find
BorjaSanchezBeezNest Jan 12, 2023
e9af84d
System: Change field to find
BorjaSanchezBeezNest Jan 12, 2023
240b2ab
System: Change field to find
BorjaSanchezBeezNest Jan 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion main/course_info/infocours.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ function is_settings_editable()
$group2[] = $form->createElement('radio', 'subscribe', get_lang('Subscription'), get_lang('Allowed'), 1);
$group2[] = $form->createElement('radio', 'subscribe', null, get_lang('Denied'), 0);

$myButton = $form->addButtonSave(get_lang('SaveSettings'), 'submit_save', true);
$myButton = $form->addButtonSave(get_lang('SaveSettings'), 'submit_save_access', true);

$group3[] = $form->createElement(
'radio',
Expand Down
4 changes: 3 additions & 1 deletion tests/behat/features/bootstrap/FeatureContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,11 @@ public function iHaveAPublicPasswordProtectedCourse($code, $password)
);
$this->pressButton('submit');
$this->visit('/main/course_info/infocours.php?cidReq='.$code);
$this->clickLink('Course access');
$this->waitForThePageToBeLoaded();
$this->assertPageContainsText('Course registration password');
$this->fillField('course_registration_password', $password);
$this->pressButton('submit_save');
$this->pressButton('update_course_submit_save_access');
$this->assertFieldContains('course_registration_password', $password);
}

Expand Down
17 changes: 7 additions & 10 deletions tests/behat/features/course.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,13 +158,10 @@ Feature: Course tools basic testing
And I am on "/main/course_info/maintenance.php"
Then I should not see an ".alert-danger" element

# Scenario: Enter to public password-protected course
# Given I have a public password-protected course named "PASSWORDPROTECTED" with password "123456"
# And I am not logged
# And I am on "/courses/PASSWORDPROTECTED/index.php"
# When I fill in "course_password" with "123456"
# And I press "submit"
# Then I should not see "The course password is incorrect"



Scenario: Enter to public password-protected course
Given I have a public password-protected course named "PASSWORDPROTECTED" with password "123456"
And I am not logged
And I am on "/courses/PASSWORDPROTECTED/index.php"
When I fill in "course_password" with "123456"
And I press "submit"
Then I should not see "The course password is incorrect"