ENT-13667: Fixed bad regex in packages promise method for pip #3099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The packages promise method for pip fails with error: ``` error: Regular expression error: 'invalid range in character class' in expression '^([[:alnum:]-_]+\s\([\d.]+\))' (offset: 13) ``` This is probably a regression after upgrading from PCRE to PCRE2. The regex engine complains about the hyphen, which has a special meaning within the square brackets. The bug is easily fixed by escaping the hyphen. Ticket: ENT-13667 Changelog: Title Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
larsewi
added
the
cherry-pick?
larsewi
removed
the
cherry-pick?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The packages promise method for pip fails with error:
This is probably a regression after upgrading from PCRE to PCRE2.
The regex engine complains about the hyphen, which has a special meaning
within the square brackets. The bug is easily fixed by escaping the
hyphen.
Ticket: ENT-13667
Changelog: Title
Signed-off-by: Lars Erik Wik lars.erik.wik@northern.tech
Back ported to #3100