ENT-14090: Stopped using system_owned in copy_from acceptance tests (3.24.x)#6132
Draft
larsewi wants to merge 1 commit into
Draft
ENT-14090: Stopped using system_owned in copy_from acceptance tests (3.24.x)#6132larsewi wants to merge 1 commit into
larsewi wants to merge 1 commit into
Conversation
After plucked.sub.cf was regenerated from masterfiles, system_owned sets group to "sys" (gid 3) on Solaris specifically. The destination file created by copy_from is created with the agent's effective gid (0), causing VerifyCopiedFileAttributes to emit an extra "Group of ... was 0, set to 3" log line that wasn't in the expected output. Use m() instead, which only sets mode and avoids the cross-platform group difference. Ticket: ENT-14090 Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After
plucked.sub.cfwas regenerated from masterfiles (commit a8a4aa2 on 3.24.x), thesystem_ownedbody sets group tosys(gid 3) on Solaris specifically. The destination file created bycopy_fromwithpreserve => "true"is opened with the agent's effective gid (0), soVerifyCopiedFileAttributesdetects the mismatch against the source's gid and emits an extraGroup of ... was 0, set to 3log line that isn't in the.expectedoutput. This caused28_inform_testing/01_files/copy_from01.cfandcopy_from03.cfto start failing on Solaris 11.Switching the setup
permsbody tom("0644")keeps the mode-only behavior the test cares about and avoids changing source ownership, so the inherited gid on the destination matches and no spurious log line appears.