ENT-13303: Fixed booleans for classes in augments #6024
Conversation
Ticket: ENT-13303 Signed-off-by: Victor Moene <victor.moene@northern.tech>
Signed-off-by: Victor Moene <victor.moene@northern.tech>
Signed-off-by: Victor Moene <victor.moene@northern.tech>
Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
boolclassesaguments
branch
from
bd8e22a to
657aa1d
Compare
| OpenLog(default_facility); | ||
| SetSyslogFacility(default_facility); | ||
|
|
||
| EvalContextClassPutHard(ctx, "any", "source=agent"); |
There was a problem hiding this comment.
Please explain why this is redundant in the commit message. It's not clear from looking at the diff.
| else if (strcmp("true", name) == 0) | ||
| { | ||
| ret = EXPRESSION_VALUE_TRUE; | ||
| } |
There was a problem hiding this comment.
Same here. Some explanation would be helpful :)
| char vbuff[CF_BUFSIZE]; | ||
|
|
||
| EvalContextClassPutHard(ctx, "any", "source=agent"); /* This is a reserved word / wildcard */ | ||
| EvalContextClassPutHard(ctx, "true", "source=agent"); |
There was a problem hiding this comment.
The ticket does not mention adding true as a hard class. I wonder if this can get some implications. It should be possible to map the JSON type true to the hard class any when parsing the augments, without adding a new hard class. Whether or not true should be a hard class or not, we can discuss with @olehermanse and @nickanderson .
There was a problem hiding this comment.
Yeah, I would be quite wary of introducing such a generic class. My concern woul d be people using it within a bundle as a bundle scoped class for some condition (like pass in tests) that all of the sudden is now always true.
3 participants
No description provided.