Made cfbs update strictly validate new versions of modules #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rationale for this is that if there are validation errors, there is a good chance something is wrong and the build will fail when it gets to the hub. We want to do what we can to prevent the hub from having a project it cannot build correctly. Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
If we introduce stricter validation rules inside modules, I think it's nice if cfbs update works so it can get the new valid version and automatically make your cfbs.json valid. Avoided the partial approach of trying to measure if your cfbs.json is more valid than before, that can quickly get hairy. Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
…tion Example error message: ``` $ cfbs --non-interactive update promise-type-ansible@0.1.0 Error: Assertion failed - assert name == module["name"] (cfbs/validate.py:377) This is an unexpected error indicating a bug, please create a ticket at: https://northerntech.atlassian.net/ (Rerun with CFBACKTRACE=1 in front of your command to show the full backtrace) ``` Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
larsewi
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.