Made validation more strict in cfbs add/remove/update/status/input #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Builds on #256 |
olehermanse
changed the title
We want cfbs build to be backwards compatible (also cfbs download). In these other commands it makes more sense to be more strict to try to catch mistakes and prevent bad situations. If cfbs versions differ, we assume the user is running a newer version and the hub is running an older version of cfbs when it's running cfbs build. In all cases, we want users to be able to upgrade cfbs and still have cfbs build work. If the user attempts to edit the project, and validation fails, it could mean: - The project was made / edited on a newer version of cfbs - The project has mistakes, for example after editing the JSON manually Both of which we want to catch and fix, by making the user upgrade cfbs and/or fix errors in the cfbs.json. Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
olehermanse
force-pushed
the
strict
branch
3 times, most recently
from
2906017 to
b4d8e1c
Compare
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
jakub-nt
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will probably warrant a major version bump since it seems relatively breaking, but I think we should do this, since it reduces the chances of someone editing a project into a state which their hub won't build correctly.