Conversation
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/cc @inteon |
There was a problem hiding this comment.
Pull request overview
This PR refactors the CRD generation process in the helm module by splitting the monolithic generate-crds target into two separate targets: generate-crds for basic CRD generation and generate-helm-crds for Helm-templated CRDs. This change removes the dependency on a temporary directory and generates CRDs directly to the final crds_dir location, simplifying the workflow and making it easier to move CRD generation out of the helm module in the future.
Changes:
- Split
generate-crdsinto two targets:generate-crds(basic CRD generation) andgenerate-helm-crds(Helm-templated CRDs) - Generate CRDs directly to
crds_dirinstead of using a temporary scratch directory - Move the
$(NEEDS_YQ)dependency fromgenerate-crdstogenerate-helm-crdssince YQ is only needed for Helm templating - Update
shared_generate_targetsto registergenerate-helm-crdsinstead ofgenerate-crdsto maintain backward compatibility
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This is the first step towards moving the CRD generation out of the helm module. Instead of using a temporary directory, I propose using the
crds_dirdirectory directly. I wish there were a way to avoid recreating the directory each time.