Skip to content

Split (helm) generate-crds target#549

Open
erikgb wants to merge 1 commit intocert-manager:mainfrom
erikgb:split-generate-crds
Open

Split (helm) generate-crds target#549
erikgb wants to merge 1 commit intocert-manager:mainfrom
erikgb:split-generate-crds

Conversation

@erikgb
Copy link
Member

@erikgb erikgb commented Feb 15, 2026

This is the first step towards moving the CRD generation out of the helm module. Instead of using a temporary directory, I propose using the crds_dir directory directly. I wish there were a way to avoid recreating the directory each time.

Signed-off-by: Erik Godding Boye <egboye@gmail.com>
@cert-manager-prow cert-manager-prow bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Feb 15, 2026
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign erikgb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 15, 2026
@erikgb
Copy link
Member Author

erikgb commented Feb 15, 2026

/cc @inteon

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the CRD generation process in the helm module by splitting the monolithic generate-crds target into two separate targets: generate-crds for basic CRD generation and generate-helm-crds for Helm-templated CRDs. This change removes the dependency on a temporary directory and generates CRDs directly to the final crds_dir location, simplifying the workflow and making it easier to move CRD generation out of the helm module in the future.

Changes:

  • Split generate-crds into two targets: generate-crds (basic CRD generation) and generate-helm-crds (Helm-templated CRDs)
  • Generate CRDs directly to crds_dir instead of using a temporary scratch directory
  • Move the $(NEEDS_YQ) dependency from generate-crds to generate-helm-crds since YQ is only needed for Helm templating
  • Update shared_generate_targets to register generate-helm-crds instead of generate-crds to maintain backward compatibility

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant