Conversation
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
cert-manager-prow
bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
size/M
| ## Verify all APIs using Kube API Linter | ||
| ## @category [shared] Generate/ Verify | ||
| verify-kube-api-lint: | $(NEEDS_GO) $(NEEDS_GOLANGCI-LINT-KUBE) $(bin_dir)/scratch | ||
| @find . -name go.mod -not \( -path "./$(bin_dir)/*" -or -path "./make/_shared/*" \) \ |
There was a problem hiding this comment.
Do we really need to find/loop here? The API types will typically reside in one Go module.
| ## Fix all APIs using Kube API Linter | ||
| ## @category [shared] Generate/ Verify | ||
| fix-kube-api-lint: | $(NEEDS_GO) $(NEEDS_GOLANGCI-LINT-KUBE) $(bin_dir)/scratch | ||
| @find . -name go.mod -not \( -path "./$(bin_dir)/*" -or -path "./make/_shared/*" \) \ |
There was a problem hiding this comment.
Same as above, to reduce complexity.
| golangci_lint_version := v2.8.0 | ||
| # https://pkg.go.dev/sigs.k8s.io/kube-api-linter?tab=versions | ||
| # renovate: datasource=go packageName=sigs.k8s.io/kube-api-linter | ||
| golangci_lint_kube_version := v0.0.0-20260114104534-18147eee9c49 |
There was a problem hiding this comment.
Wouldn't kube_api_linter_version be a better name for this variable? (And the same for similar/deduced variables)
cert-manager-prow
bot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
2 participants
Created a module for the
sigs.k8s.io/kube-api-linterlinter.first version, still wip