Fix: add batch limit for stackdriver exporter#644
Fix: add batch limit for stackdriver exporter#644mayurkale22 wants to merge 1 commit intocensus-instrumentation:masterfrom
Conversation
|
/cc @mluggy Please review. |
|
@draffensperger Please review when you have a time. |
| } | ||
|
|
||
| it('should return a partition lists', () => { | ||
| const list = partitionList(timeSeriesList, 200); |
There was a problem hiding this comment.
Would it make sense to test the exporter directly rather than the helper function? That would enable check that the helper function is used correctly and would implicitly check the helper (which could then even be made non-exported).
I'm open to leaving as-is for now if you prefer though.
|
Can we merge this and get a release? |
|
I'd like to mention another, related problem with exporting Metrics to Stackdriver:
(used to be even only 1 per minute in December 2019 when I run into this problem) its still ridiculously low for per-request metrics and also causes millions of API errors, eating up memory and CPU in your service if you dont implement some throttling yourself this caused us to not even start using Stackdriver Monitoring for custom metrics but ended up using Prometheus again. |
JanSunavec
left a comment
JanSunavec
left a comment
There was a problem hiding this comment.
Tested in kubernetes production and it's working.
|
Is there a reason this isn't released yet? I'm running into the same issue as #634 |
|
Would be quite nice if this got some attention again. Kinda makes it barely usable with stackdriver. |
|
We're seeing this issue ourselves, is there any workaround available? |
|
I guess there won't be much love for opencensus anymore as it's deprecated in favor of opentelemetry |
|
Bah, that would probably explain it. Of course the GCP docs I read must've been out of date. Thanks for the FYI. |
9 participants
Fixes #634
These changes have all been tested locally against a real stackdriver exporter and been confirmed to be working.