This repository was archived by the owner on Oct 3, 2023. It is now read-only.
[PROPOSAL] feat(tracer): separate cls out of tracer#498
Open
hekike wants to merge 1 commit intocensus-instrumentation:masterfrom
Open
[PROPOSAL] feat(tracer): separate cls out of tracer#498hekike wants to merge 1 commit intocensus-instrumentation:masterfrom
hekike wants to merge 1 commit intocensus-instrumentation:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #498 +/- ##
==========================================
+ Coverage 94.93% 94.94% +<.01%
==========================================
Files 145 145
Lines 10195 9915 -280
Branches 872 865 -7
==========================================
- Hits 9679 9414 -265
+ Misses 516 501 -15
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is work in progress...
On the meeting with @bogdandrutu there was this idea to have a pure Tracer API and making Span creation synchronous and turning CLS to a layer top of the pure Tracer API. This PR experiments with this API with the current Opencensus Node library.
(CLS needs an async fn to carry on context)
Pure synchronous Tracer APIs:
CLS layer top of the pure API + sugar
startWithRootSpanthat combines both span creation and cls context set:An additional benefit of this API is that using
withSpandeveloper could chain spans in CLS and client RPCs like gRPC would start from the correct contextual child span.