Core - Add chrome_policy_id to CefSettings#5227
Core - Add chrome_policy_id to CefSettings#5227strau0106 wants to merge 1 commit intocefsharp:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdded a public Changes
Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
❌ Build CefSharp 146.0.60-CI5444 failed (commit dafdb1ee28 by @strau0106) |
Summary:
Cef allows a chrome_policy_id to be set, to allow for an enterprise policy to be set. Cef introduced this feature here
Changes:
I added a ChromePolicyID field to the relevant locations, to allow this id to be set in the cef_settings object.
How Has This Been Tested?
I tested if the policies are loaded, which they are. To test chrome policy commandline argument also has to be set.
Screenshots (if appropriate):
Types of changes
Checklist:
Summary by CodeRabbit
ChromePolicyIdproperty to application settings, enabling configuration and management of Chrome Policy identifiers.