Conversation
There was a problem hiding this comment.
Hello and thanks for your contribution @Pcornat
Could you explain what doesn't work for you today?
For example, re: RPM build, right now we're using %pyproject_* macros are not strictly tied to pyproject.toml and they work with the legacy setup.py/setup.cfg combo:
https://src.fedoraproject.org/rpms/clustershell/blob/rawhide/f/clustershell.spec
So #587 is actually already fixed without using a pyproject.toml
Adding your pyproject.toml will likely break the build on EL9 and EL10. That said, we could decide to move forward and include it, handling EL builds separately, if there is a good reason for it.
That said, a minimal pyproject.toml with just the [build-system] declaration (no [project] table, keeping metadata in setup.py/setup.cfg) could be useful for pip install -e . workflows and would work across all platforms without the setuptools version constraints? Would that work for you?
|
Hello @thiell As the issue is not closed, I thought the problem was still here. So now I think my contribution is useless (?). Would it be possible to close the issue #587 to know that the problem is yesterday's news ? Plus, removing the |
I made a
pyproject.tomlfile to resolve an issue. I tested only thepip install -e .command.I made a small change to introduce
setuptools-scmto make the build process get package's version from git tags.Feel free to do whatever is needed to make it compliant with the project and to solve the issue.
Resolves #587