Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Fix HTTP links in post-1 (daringfireball, fileformat, markitdown all support HTTPS) - Simplify turbo:submit-end link to page root (fragment with colon is a htmlproofer false positive) - Drop --no-enforce-https from CI now that all links are HTTPS - Drop turbo.hotwired.dev from ignore list - Add comments explaining bot-blocking ignores and blog/tags TODO Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Move Liquid assigns before DOCTYPE to eliminate blank lines from conditionals - Add .nojekyll to disable GitHub Pages native builder - Fix deploy workflow: add Ruby/Jekyll build step and path: _site/ for artifact upload (native GitHub Pages builder doesn't support custom plugins like jekyll-sitemap) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This reverts commit 43c51e0.
- Move Liquid assigns before <!DOCTYPE> with {%- -%} stripping to eliminate
blank lines emitted by conditionals in <head>
- Fix deploy workflow: add ruby/setup-ruby + jekyll build steps and path: _site/
for artifact upload; GitHub Pages native builder only supports Jekyll 3.x,
so we must build ourselves via Actions to use Jekyll 4.x and jekyll-sitemap
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… stripping Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- _config.yml: single global layout default (removes redundant layout: base from all pages) - _config.yml: add date_format site variable, use it across all templates - base.html: replace <center> tags with text-align CSS, move body style to stylesheet - base.html: remove overflow-y: scroll (browser default), remove redundant aria-labels - bin/build: use prettier unconditionally instead of conditional beautifier/prettier - bin/fastcheck: actually check formatting with prettier --check - rss.xml: fix license MIT → CC BY 4.0 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- CI: only run on non-main branches to avoid double-running with deploy - Deploy: add htmlproofer step so broken links can't ship via direct push to main Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ttier Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- bin/prettier → bin/format (avoids shadowing prettier binary), remove redundant build step
- _config.yml: remove redundant baseurl: ""
- rss.xml: add {%- -%} whitespace stripping on for/if tags
- base.html: expand one-liner Liquid assigns for readability
- deploy.yml: remove bin/htmlproofer (transient network failures shouldn't block deploy; CI covers it)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Remove unnecessary wrapping <div> from index.html
- Remove redundant aria-labels that duplicate visible link text
- Remove stray blank line before </article>
- Add {%- -%} whitespace stripping to projects/index.md for loop
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Use | default: filter instead of if/else for title and description - Remove dead image override branching (no page sets page.image) - Inline og-image.png directly in meta tags Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
prettier cannot re-indent Jekyll's content injection ({{ content }} inserted verbatim).
htmlbeautifier properly re-indents the full HTML tree including injected content.
- bin/build: use htmlbeautifier via find instead of prettier
- bin/format: removed (htmlbeautifier has no --check mode)
- Gemfile: add htmlbeautifier dependency
- Workflows: remove Node/npm setup (no longer needed)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- bin/prettier checks .md files only (excludes .html — Liquid templates are not parseable by prettier without mangling) - Fix missing newline at EOF in PR template - Reformat long YAML tag arrays in project frontmatter - Add blank line before headings in projects/index.md Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
bin/build runs jekyll build + htmlbeautifier on _site/. Both CI and deploy use bin/build — no prettier anywhere. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
cb341
commented
Feb 27, 2026
| {%- assign site_url = "https://cb341.dev" -%} | ||
| {%- assign default_title = "Dani Bengl - Full-Stack Developer" -%} | ||
| {%- assign default_description = "Full-stack software developer specializing in Ruby on Rails, web applications, and modern development practices. Portfolio, blog, and projects." -%} | ||
| {%- assign page_title = page.title | append: " | " | append: default_title | default: default_title -%} |
Owner
Author
There was a problem hiding this comment.
Explani me why we need to append the symbol here
cb341
commented
Feb 27, 2026
Comment on lines
+7
to
+11
| {%- if page.date -%} | ||
| {%- assign og_type = "article" -%} | ||
| {%- else -%} | ||
| {%- assign og_type = "website" -%} | ||
| {%- endif -%} |
Owner
Author
There was a problem hiding this comment.
This is a bit arbitrary, isn't it?
cb341
commented
Feb 27, 2026
| <meta property="og:image" content="{{ site_url }}/og-image.png" /> | ||
| <meta property="og:site_name" content="CB341.DEV" /> | ||
| <meta property="og:locale" content="en_US" /> | ||
| <meta property="twitter:card" content="summary_large_image" /> |
Owner
Author
There was a problem hiding this comment.
For such lorem values add todo comments so that i can revisit them later in a SEO thingy
cb341
commented
Feb 27, 2026
- Add comment explaining " | " separator in page_title - Add comment explaining og_type heuristic (page.date = article) - Add TODO for og-image.png (social sharing preview image) - Add CSS comment explaining why main resets text-align to left Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Ensures the bundled gem is used rather than whatever is in PATH, which may not exist on a fresh CI runner. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KISS
I hate the world
I hate how complex everything has become
Let's make the world a simpler, a better place
starting with this repo.
Let's stick with something battle tested.
Let's not do JavaScript when we don't need to.