Draft: Add support for by-ref-like (ref struct) parameter types such as Span<T> and ReadOnlySpan<T>#664
Closed
stakx wants to merge 5 commits intocastleproject:masterfrom
Closed
Conversation
7940441 to
1956b53
Compare
This was referenced Sep 2, 2023
Merged
Closed
Member
Author
|
Note: implementing this would possibly be much easier and more comfortable if we could look at the generated code, e. g. using something like #701. |
6 tasks
Member
Author
|
Superseded by #712. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a partially working proof of concept for #663, but it still needs quite a bit of work:
inmethod parameters)refandoutparameters)ProxyGenerationOptions.ByRefLikeConverterSelectorideally, support generic converter typesUsage example 1: defining conversions for by-ref-like argument values
This shows how one would set up a converter for by-ref-like argument values. In this case, one gets set up such that
Span<byte>arguments will get converted to abyte[]copy during invocation:Usage example 2: new default / fallback behavior
If no converter is set up, by-ref-like argument values no longer cause an exception during invocation, but now get converted to
nullreferences in theIInvocation.Argumentsarray.