dashboard: Fix reindexing of published realms#5041
Open
backspace wants to merge 2 commits into
Open
Conversation
Contributor
Host Test Results 1 files 1 suites 1h 36m 11s ⏱️ Results for commit a2d0d5f. Realm Server Test Results 1 files ±0 1 suites ±0 11m 49s ⏱️ +25s Results for commit a2d0d5f. ± Comparison against earlier commit e4fcad3. |
The grafana reindex handler rejected any realm= value whose origin differed from the server's own URL. Published realms legitimately live on a different domain than the server that hosts them, so reindexing one from the internal dashboard failed with "realm must be a path under this server". Drop the origin/pathname guard and rely on reconciler.lookupOrMount, which already gates on registry membership (a parameterized WHERE url lookup that never fetches the input URL). Any hosted realm — source or published, on any domain — is now reindexable, while off-registry values still fall through to the existing "does not exist" 400 and the endpoint stays behind grafana authorization. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
backspace
force-pushed
the
dashboard-reindex-published-cs-11307
branch
from
e4fcad3 to
a2d0d5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The redacted URL is a published realm, which doesn’t live under the realm server domain.
With this branch deployed, reindexing succeeded: