Skip to content

Prevent duplicate stack opens when clicking submission workflow listing#4387

Open
lucaslyl wants to merge 2 commits intomainfrom
CS-10685/clicking-on-listing-attached-to-submission-workflow-card-will-open-up
Open

Prevent duplicate stack opens when clicking submission workflow listing#4387
lucaslyl wants to merge 2 commits intomainfrom
CS-10685/clicking-on-listing-attached-to-submission-workflow-card-will-open-up

Conversation

@lucaslyl
Copy link
Copy Markdown
Contributor

linear: https://linear.app/cardstack/issue/CS-10685/prevent-duplicate-stack-opens-when-clicking-submission-workflow

Root cause: the listing click was handled twice.

  1. ListingFittedTemplate has {{on 'click' this.viewDetails}}, and viewDetails() calls listingActions.view() (which runs show-card).
  2. Operator mode overlays also attach a click handler to linked cards and open the card.
  3. One click on the listing in SubmissionWorkflowCard triggered both paths, so two stack opens occurred.

Fix

viewDetails now accepts the click event and calls event.stopPropagation() before listingActions.view().

Screen.Recording.2026-04-13.at.1.13.27.PM.mov

@lucaslyl lucaslyl self-assigned this Apr 13, 2026
@lucaslyl lucaslyl requested a review from a team April 13, 2026 05:15
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 13, 2026

Host Test Results

2 194 tests  ±0   2 179 ✅ ±0   2h 20m 38s ⏱️ - 1m 25s
    1 suites ±0      15 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 3c10c57. ± Comparison against base commit b5cd4a5.

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Contributor

@richardhjtan richardhjtan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Please also make the changes inside boxel-catalog too. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants