Fix isolated realm server teardown in software-factory test harness (CS-10472)

[habdelra]

Summary

• Spawn ts-node directly instead of pnpm serve:realm to eliminate the intermediate wrapper process that broke process-group killing during teardown
• Add port-free verification after stop() to confirm ports 4205/4201/4232 are released before the next test starts
• Add process.on('exit') safety net in serve-realm.ts that force-kills child processes on unclean exit
• Consolidate the bifurcated playwright configs (playwright.config.ts, playwright.e2e.config.ts, playwright.shared.ts) back into a single playwright.config.ts — all specs now run together under pnpm test:playwright
• Remove the test:playwright-e2e workaround script from package.json
• Remove the CS-10472 workaround comment from factory-target-realm.spec.ts

Dependencies

Note: PR #4222 must be reviewed and merged first — this PR is based on that branch and builds on its test infrastructure.

Test plan

• pnpm test:playwright — all 8 tests pass (darkfactory, factory-bootstrap, factory-target-realm specs running together)
• Back-to-back runs succeed with no port conflicts
• No orphaned processes after test completion (ss -tlnp shows no lingering listeners on 4201/4205/4232)
• pnpm lint:js and pnpm lint:format pass

Related

• Depends on: Implement project artifact bootstrap from a brief #4222 (CS-10449)
• Follow-up: CS-10485 (dynamic port allocation for parallel workers)
• Linear: https://linear.app/cardstack/issue/CS-10472

🤖 Generated with Claude Code

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[Copilot]

Pull request overview

This PR primarily hardens the packages/software-factory Playwright test harness teardown for isolated realm servers (CS-10472), aiming to prevent orphaned processes and port conflicts between specs, and it simplifies Playwright configuration so all specs run together.

Changes:

• Replace pnpm serve:* wrapper process spawning with direct ts-node CLI invocation to improve process-group teardown reliability.
• Add post-stop() verification that key ports are released before subsequent tests start.
• Consolidate Playwright configs/scripts so all specs run under pnpm test:playwright.

Reviewed changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
pnpm-lock.yaml	Updates patch hash for monaco-editor patch contents.
patches/monaco-editor@0.52.2.patch	Suppresses Monaco diff worker null-result error when models are disposed mid-computation.
packages/software-factory/tests/fixtures.ts	Spawns ts-node directly and adds waitForPortFree() checks after teardown.
packages/software-factory/tests/factory-target-realm.spec.ts	Removes CS-10472 workaround comment now that teardown is addressed.
packages/software-factory/src/harness.ts	Exposes child process PIDs from the isolated stack for cleanup.
packages/software-factory/src/cli/serve-realm.ts	Adds process.on('exit') safety net to SIGKILL child PIDs on unclean exit.
packages/software-factory/playwright.shared.ts	Deleted; config consolidated into a single Playwright config.
packages/software-factory/playwright.global-setup.ts	Spawns ts-node directly for serve-support.
packages/software-factory/playwright.e2e.config.ts	Deleted; e2e tests now run with the main config.
packages/software-factory/playwright.config.ts	Single unified config that runs all *.spec.ts together.
packages/software-factory/package.json	Removes test:playwright-e2e script.
packages/software-factory/docs/software-factory-testing-strategy.md	Updates docs to include a “test realm” and AI-generated test loop.
packages/software-factory/docs/one-shot-factory-go-plan.md	Expands docs around test realm + implement→test→iterate loop; adds model flag note.
packages/runtime-common/loader.ts	Adds caching for known module dependencies and uses string-based module-id trimming.
packages/runtime-common/dependency-tracker.ts	Replaces URL-constructor heavy normalization with string-based normalization.
packages/realm-server/prerender/render-runner.ts	Routes reproduce log line to a separate logger name.
packages/base/card-api.gts	Updates comment to reflect loader perf improvements.
.github/workflows/pr-review-reminder.yml	Adds scheduled workflow to post awaiting-review PRs to Discord.

Files not reviewed (1)

• pnpm-lock.yaml: Language not supported

Comments suppressed due to low confidence (1)

packages/software-factory/src/cli/serve-realm.ts:62

• The SIGINT/SIGTERM handlers call the async stop() without handling rejections. If runtime.stop() throws, this becomes an unhandled promise rejection and may leave the process running without exiting (and without triggering the exit cleanup). Consider attaching a .catch() that logs and sets a non-zero exit code, and/or setting cleanExit intent earlier so the exit handler behavior is deterministic.

  let stop = async () => {
    await runtime.stop();
    cleanExit = true;
    process.exit(0);
  };

  process.on('SIGINT', () => void stop());
  process.on('SIGTERM', () => void stop());

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

Host Test Results

    1 files      1 suites   2h 6m 51s ⏱️
2 030 tests 2 015 ✅ 15 💤 0 ❌
2 045 runs  2 030 ✅ 15 💤 0 ❌

Results for commit 7be0c51.

♻️ This comment has been updated with latest results.

[github-actions]

Preview deployments

• Host staging preview
• Host production preview