-
Notifications
You must be signed in to change notification settings - Fork 12
Add endpoint and button to download realm #3935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ffc3fe9
Add dependencies
backspace d8353cb
Add preliminary test
backspace a3f96c9
Add preliminary handler
backspace 6e430de
Fix delivery of archive
backspace ba7ebd8
Add preliminary download button
backspace aa1daba
Update styles a bit
backspace 4406ffa
Fix appearance of download button
backspace b95881a
Fix lint errors
backspace 0bb6116
Fix type errors
backspace 55a82c5
Remove nesting
backspace df520db
Add whitespace
backspace 23b011f
Extract helper function to fix Glint failure
backspace ac50cf1
Add more tests
backspace 89ee663
Remove unnecessary escapes
backspace 099ce9f
Fix import order
backspace e85d0ed
Merge branch 'main' into download-realm-cs-10134
backspace File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| export function extractFilename( | ||
| contentDisposition: string | null, | ||
| ): string | null { | ||
| if (!contentDisposition) { | ||
| return null; | ||
| } | ||
| let utf8Match = contentDisposition.match(/filename\\*=UTF-8''([^;]+)/i); | ||
| if (utf8Match?.[1]) { | ||
| return decodeURIComponent(utf8Match[1]); | ||
| } | ||
| let match = contentDisposition.match(/filename="?([^";]+)"?/i); | ||
| return match?.[1] ?? null; | ||
| } | ||
|
|
||
| export function fallbackDownloadName(realmURL: URL) { | ||
| let segments = realmURL.pathname.split('/').filter(Boolean); | ||
| let base = | ||
| segments.length >= 2 | ||
| ? segments.slice(-2).join('-') | ||
| : (segments[0] ?? realmURL.hostname); | ||
| base = base.replace(/[^a-zA-Z0-9._-]+/g, '-').replace(/^-+|-+$/g, ''); | ||
| return base.length > 0 ? `${base}.zip` : 'realm.zip'; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can see the errors here. I tried for a while to come up with a better way, including splitting the template, moving the functions outside the class… this was the only way I found that worked.