Recursively inject on into combinator filter leaves #3931
Conversation
…ryDefinition Previously, `normalizeQueryDefinition` only injected the `on` reference at the top-level filter. Combinator filters (not, any, every) left their inner leaf attribute filters without `on`, producing invalid filter structures. This adds a recursive walk that injects `on` into each leaf filter (eq, contains, range) that lacks one, while skipping type filters. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Preview deployments |
Host Test Results 1 files ± 0 1 suites ±0 2h 40m 4s ⏱️ + 56m 34s For more details on these failures, see this check. Results for commit 4452a15. ± Comparison against base commit bc47720. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Pull request overview
This PR enhances normalizeQueryDefinition to recursively inject the on property into leaf attribute filters within combinator filters (not, any, every), ensuring all leaf filters have the proper scope reference.
Changes:
- Replaced simple
oninjection with recursive traversal of filter trees - Added
injectOnIntoLeafFiltersfunction to handle nested combinator filters - Added comprehensive test coverage for nested filter scenarios
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/runtime-common/query-field-utils.ts | Implements recursive filter tree traversal logic to inject on into leaf filters while preserving combinator structure |
| packages/host/tests/unit/query-field-normalization-test.ts | Adds test cases for not, any, every combinators, deeply nested filters, type filter handling, and existing on preservation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
normalizeQueryDefinitionnow recursively walks the filter tree to injectoninto leaf attribute filters (eq,contains,range) that lack onenot,any,every) are traversed without injection at their leveltypefilters (self-scoping) are skippedonreferences on leaf filters are preservedFixes CS-10126
🤖 Generated with Claude Code