server: Add realm endpoint for writing binary files #3930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview deployments |
lukemelia
force-pushed
the
cs-10076-realm-endpoint-for-writing-a-binary-file
branch
from
6cc9a9c to
c1b01d1
Compare
Add a POST route for `application/octet-stream` that accepts binary uploads (images, etc.) and writes them through the existing `Realm.write()` pipeline. Widens write signatures across the adapter interface, node adapter, test adapter, and realm methods to accept `string | Uint8Array`. Applies the same size limit and response shape as `upsertCardSource`. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
lukemelia
force-pushed
the
cs-10076-realm-endpoint-for-writing-a-binary-file
branch
from
c1b01d1 to
7961c65
Compare
Host Test Results 1 files ± 0 1 suites ±0 3h 37m 49s ⏱️ + 1h 54m 19s For more details on these errors, see this check. Results for commit 1ca156d. ± Comparison against base commit bc47720. ♻️ This comment has been updated with latest results. |
* Host mode stack layering and scroll fixes * test update * remove unneeded transitions
Cards should not break out of their bounding box, so warn the AI bot against using `position: fixed` in card styles via the _lint endpoint. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Use GlimmerElementNode (not GlimmerElement) to match the AST type produced by ember-eslint-parser - Fix prettier formatting in integration test - Add unit tests for the rule in eslint-plugin-boxel covering valid cases (relative, absolute, sticky, no style) and invalid cases (with/without space, extra whitespace, multiple occurrences) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The eslint-plugin-boxel package has unit tests that were not being run in CI. Add a dedicated path filter and test job so regressions in custom ESLint rule logic are caught. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…(instead of user-wide)
The fetchRequestFromContext middleware was converting all POST request bodies to UTF-8 text, corrupting binary data. Now checks Content-Type for application/octet-stream and preserves raw bytes using a Buffer. Also relaxes the test helper's file path validation to accept any file extension, not just .json and .gts. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
POSTroute forapplication/octet-streamthat accepts binary uploads (images, etc.) and writes them through the existingRealm.write()pipelineRealmAdapter,NodeAdapter,TestRealmAdapter, andRealmto acceptstring | Uint8ArrayvalidateWriteSize()to handleUint8Arraydirectlytypeof content === 'string'guards in_batchWrite()so JSON parsing and card document detection are skipped for binary contentlast-modified,x-created) asupsertCardSourceCloses CS-10076
Test plan
🤖 Generated with Claude Code