eds: Style and type fixes around build_variable()#661
Merged
friederschueler merged 4 commits intocanopen-python:masterfrom May 7, 2026
Merged
eds: Style and type fixes around build_variable()#661friederschueler merged 4 commits intocanopen-python:masterfrom
friederschueler merged 4 commits intocanopen-python:masterfrom
Conversation
Pass object type to build_variable() instead of the boolean is_domain parameter. Add type hints to aid in validating all call sites have been adjusted.
The storage_location attribute needs an explicit annotation (assumed only None type) on the OD variable classes, to accept strings from eds. Silence mypy in import_eds() for a custom attribute addition.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
friederschueler
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This essentially fixes the outstanding style issues I noted in #655, slightly cleaning up that module.