Skip to content

Add automatic platform detection from scheme build settings #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jjfeiler wants to merge 3 commits into from
+559 −110
Closed

Add automatic platform detection from scheme build settings #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b26304c
Add automatic platform detection from scheme build settings
jjfeiler Feb 1, 2026
e9424cb
Fix Prettier formatting issues
jjfeiler Feb 2, 2026
0254430
Tighten simulator platform detection heuristics
cameroncooke Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
117 changes: 53 additions & 64 deletions src/mcp/tools/simulator/__tests__/build_run_sim.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,19 @@ describe('build_run_sim tool', () => {
const mockExecutor: CommandExecutor = async (command) => {
callCount++;
if (callCount === 1) {
// First call: build succeeds
// First call: platform detection succeeds
return createMockCommandResponse({
success: true,
output: 'BUILD SUCCEEDED',
output: 'SDKROOT = iphonesimulator\nSUPPORTED_PLATFORMS = iphonesimulator iphoneos',
});
} else if (callCount === 2) {
// Second call: showBuildSettings fails to get app path
// Second call: build succeeds
return createMockCommandResponse({
success: true,
output: 'BUILD SUCCEEDED',
});
} else if (callCount === 3) {
// Third call: showBuildSettings fails to get app path
return createMockCommandResponse({
success: false,
error: 'Could not get build settings',
Expand Down Expand Up @@ -258,9 +264,13 @@ describe('build_run_sim tool', () => {
trackingExecutor,
);

// Should generate the initial build command
expect(callHistory).toHaveLength(1);
expect(callHistory[0].command).toEqual([
// Should generate two commands: platform detection + build
expect(callHistory).toHaveLength(2);
// First call is platform detection
expect(callHistory[0].command[0]).toBe('xcodebuild');
expect(callHistory[0].command).toContain('-showBuildSettings');
// Second call is the actual build
expect(callHistory[1].command).toEqual([
'xcodebuild',
'-workspace',
'/path/to/MyProject.xcworkspace',
Expand All @@ -273,7 +283,7 @@ describe('build_run_sim tool', () => {
'platform=iOS Simulator,name=iPhone 16,OS=latest',
'build',
]);
expect(callHistory[0].logPrefix).toBe('iOS Simulator Build');
expect(callHistory[1].logPrefix).toBe('iOS Simulator Build');
});

it('should generate correct build command after finding simulator', async () => {
Expand All @@ -285,26 +295,16 @@ describe('build_run_sim tool', () => {
}> = [];

let callCount = 0;
// Create tracking executor that succeeds on first call (list) and fails on second
// Create tracking executor: platform detection, then build (fails)
const trackingExecutor: CommandExecutor = async (command, logPrefix, useShell, opts) => {
callHistory.push({ command, logPrefix, useShell, opts });
callCount++;

if (callCount === 1) {
// First call: simulator list succeeds
// First call: platform detection succeeds
return createMockCommandResponse({
success: true,
output: JSON.stringify({
devices: {
'iOS 16.0': [
{
udid: 'test-uuid-123',
name: 'iPhone 16',
state: 'Booted',
},
],
},
}),
output: 'SDKROOT = iphonesimulator\nSUPPORTED_PLATFORMS = iphonesimulator iphoneos',
error: undefined,
});
} else {
Expand All @@ -326,39 +326,29 @@ describe('build_run_sim tool', () => {
trackingExecutor,
);

// Should generate build command and then build settings command
// Should generate platform detection and then build command
expect(callHistory).toHaveLength(2);

// First call: build command
expect(callHistory[0].command).toEqual([
'xcodebuild',
'-workspace',
'/path/to/MyProject.xcworkspace',
'-scheme',
'MyScheme',
'-configuration',
'Debug',
'-skipMacroValidation',
'-destination',
'platform=iOS Simulator,name=iPhone 16,OS=latest',
'build',
]);
expect(callHistory[0].logPrefix).toBe('iOS Simulator Build');
// First call: platform detection
expect(callHistory[0].command[0]).toBe('xcodebuild');
expect(callHistory[0].command).toContain('-showBuildSettings');
expect(callHistory[0].logPrefix).toBe('Platform Detection');

// Second call: build settings command to get app path
// Second call: build command (which fails)
expect(callHistory[1].command).toEqual([
'xcodebuild',
'-showBuildSettings',
'-workspace',
'/path/to/MyProject.xcworkspace',
'-scheme',
'MyScheme',
'-configuration',
'Debug',
'-skipMacroValidation',
'-destination',
'platform=iOS Simulator,name=iPhone 16,OS=latest',
'build',
]);
expect(callHistory[1].logPrefix).toBe('Get App Path');
expect(callHistory[1].logPrefix).toBe('iOS Simulator Build');
});

it('should generate correct build settings command after successful build', async () => {
Expand All @@ -370,26 +360,16 @@ describe('build_run_sim tool', () => {
}> = [];

let callCount = 0;
// Create tracking executor that succeeds on first two calls and fails on third
// Create tracking executor: platform detection, build, then build settings for app path
const trackingExecutor: CommandExecutor = async (command, logPrefix, useShell, opts) => {
callHistory.push({ command, logPrefix, useShell, opts });
callCount++;

if (callCount === 1) {
// First call: simulator list succeeds
// First call: platform detection succeeds
return createMockCommandResponse({
success: true,
output: JSON.stringify({
devices: {
'iOS 16.0': [
{
udid: 'test-uuid-123',
name: 'iPhone 16',
state: 'Booted',
},
],
},
}),
output: 'SDKROOT = iphonesimulator\nSUPPORTED_PLATFORMS = iphonesimulator iphoneos',
error: undefined,
});
} else if (callCount === 2) {
Expand Down Expand Up @@ -420,11 +400,16 @@ describe('build_run_sim tool', () => {
trackingExecutor,
);

// Should generate build command and build settings command
expect(callHistory).toHaveLength(2);
// Should generate platform detection, build command, and build settings command
expect(callHistory).toHaveLength(3);

// First call: platform detection
expect(callHistory[0].command[0]).toBe('xcodebuild');
expect(callHistory[0].command).toContain('-showBuildSettings');
expect(callHistory[0].logPrefix).toBe('Platform Detection');

// First call: build command
expect(callHistory[0].command).toEqual([
// Second call: build command
expect(callHistory[1].command).toEqual([
'xcodebuild',
'-workspace',
'/path/to/MyProject.xcworkspace',
Expand All @@ -437,10 +422,10 @@ describe('build_run_sim tool', () => {
'platform=iOS Simulator,name=iPhone 16',
'build',
]);
expect(callHistory[0].logPrefix).toBe('iOS Simulator Build');
expect(callHistory[1].logPrefix).toBe('iOS Simulator Build');

// Second call: build settings command
expect(callHistory[1].command).toEqual([
// Third call: build settings command for app path
expect(callHistory[2].command).toEqual([
'xcodebuild',
'-showBuildSettings',
'-workspace',
Expand All @@ -452,7 +437,7 @@ describe('build_run_sim tool', () => {
'-destination',
'platform=iOS Simulator,name=iPhone 16',
]);
expect(callHistory[1].logPrefix).toBe('Get App Path');
expect(callHistory[2].logPrefix).toBe('Get App Path');
});

it('should handle paths with spaces in command generation', async () => {
Expand Down Expand Up @@ -482,9 +467,13 @@ describe('build_run_sim tool', () => {
trackingExecutor,
);

// Should generate build command first
expect(callHistory).toHaveLength(1);
expect(callHistory[0].command).toEqual([
// Should generate two commands: platform detection + build
expect(callHistory).toHaveLength(2);
// First call is platform detection
expect(callHistory[0].command[0]).toBe('xcodebuild');
expect(callHistory[0].command).toContain('-showBuildSettings');
// Second call is the actual build with paths containing spaces
expect(callHistory[1].command).toEqual([
'xcodebuild',
'-workspace',
'/Users/dev/My Project/MyProject.xcworkspace',
Expand All @@ -497,7 +486,7 @@ describe('build_run_sim tool', () => {
'platform=iOS Simulator,name=iPhone 16 Pro,OS=latest',
'build',
]);
expect(callHistory[0].logPrefix).toBe('iOS Simulator Build');
expect(callHistory[1].logPrefix).toBe('iOS Simulator Build');
});
});

Expand Down
60 changes: 40 additions & 20 deletions src/mcp/tools/simulator/__tests__/build_sim.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,9 +217,13 @@ describe('build_sim tool', () => {
trackingExecutor,
);

// Should generate one build command
expect(callHistory).toHaveLength(1);
expect(callHistory[0].command).toEqual([
// Should generate two commands: platform detection + build
expect(callHistory).toHaveLength(2);
// First call is platform detection
expect(callHistory[0].command[0]).toBe('xcodebuild');
expect(callHistory[0].command).toContain('-showBuildSettings');
// Second call is the actual build
expect(callHistory[1].command).toEqual([
'xcodebuild',
'-workspace',
'/path/to/MyProject.xcworkspace',
Expand All @@ -232,7 +236,7 @@ describe('build_sim tool', () => {
'platform=iOS Simulator,name=iPhone 16,OS=latest',
'build',
]);
expect(callHistory[0].logPrefix).toBe('iOS Simulator Build');
expect(callHistory[1].logPrefix).toBe('iOS Simulator Build');
});

it('should generate correct build command with minimal parameters (project)', async () => {
Expand Down Expand Up @@ -262,9 +266,13 @@ describe('build_sim tool', () => {
trackingExecutor,
);

// Should generate one build command
expect(callHistory).toHaveLength(1);
expect(callHistory[0].command).toEqual([
// Should generate two commands: platform detection + build
expect(callHistory).toHaveLength(2);
// First call is platform detection
expect(callHistory[0].command[0]).toBe('xcodebuild');
expect(callHistory[0].command).toContain('-showBuildSettings');
// Second call is the actual build
expect(callHistory[1].command).toEqual([
'xcodebuild',
'-project',
'/path/to/MyProject.xcodeproj',
Expand All @@ -277,7 +285,7 @@ describe('build_sim tool', () => {
'platform=iOS Simulator,name=iPhone 16,OS=latest',
'build',
]);
expect(callHistory[0].logPrefix).toBe('iOS Simulator Build');
expect(callHistory[1].logPrefix).toBe('iOS Simulator Build');
});

it('should generate correct build command with all optional parameters', async () => {
Expand Down Expand Up @@ -311,9 +319,13 @@ describe('build_sim tool', () => {
trackingExecutor,
);

// Should generate one build command with all parameters
expect(callHistory).toHaveLength(1);
expect(callHistory[0].command).toEqual([
// Should generate two commands: platform detection + build
expect(callHistory).toHaveLength(2);
// First call is platform detection
expect(callHistory[0].command[0]).toBe('xcodebuild');
expect(callHistory[0].command).toContain('-showBuildSettings');
// Second call is the actual build with all parameters
expect(callHistory[1].command).toEqual([
'xcodebuild',
'-workspace',
'/path/to/MyProject.xcworkspace',
Expand All @@ -329,7 +341,7 @@ describe('build_sim tool', () => {
'--verbose',
'build',
]);
expect(callHistory[0].logPrefix).toBe('iOS Simulator Build');
expect(callHistory[1].logPrefix).toBe('iOS Simulator Build');
});

it('should handle paths with spaces in command generation', async () => {
Expand Down Expand Up @@ -359,9 +371,13 @@ describe('build_sim tool', () => {
trackingExecutor,
);

// Should generate one build command with paths containing spaces
expect(callHistory).toHaveLength(1);
expect(callHistory[0].command).toEqual([
// Should generate two commands: platform detection + build
expect(callHistory).toHaveLength(2);
// First call is platform detection
expect(callHistory[0].command[0]).toBe('xcodebuild');
expect(callHistory[0].command).toContain('-showBuildSettings');
// Second call is the actual build with paths containing spaces
expect(callHistory[1].command).toEqual([
'xcodebuild',
'-workspace',
'/Users/dev/My Project/MyProject.xcworkspace',
Expand All @@ -374,7 +390,7 @@ describe('build_sim tool', () => {
'platform=iOS Simulator,name=iPhone 16 Pro,OS=latest',
'build',
]);
expect(callHistory[0].logPrefix).toBe('iOS Simulator Build');
expect(callHistory[1].logPrefix).toBe('iOS Simulator Build');
});

it('should generate correct build command with useLatestOS set to true', async () => {
Expand Down Expand Up @@ -405,9 +421,13 @@ describe('build_sim tool', () => {
trackingExecutor,
);

// Should generate one build command with OS=latest
expect(callHistory).toHaveLength(1);
expect(callHistory[0].command).toEqual([
// Should generate two commands: platform detection + build
expect(callHistory).toHaveLength(2);
// First call is platform detection
expect(callHistory[0].command[0]).toBe('xcodebuild');
expect(callHistory[0].command).toContain('-showBuildSettings');
// Second call is the actual build with OS=latest
expect(callHistory[1].command).toEqual([
'xcodebuild',
'-workspace',
'/path/to/MyProject.xcworkspace',
Expand All @@ -420,7 +440,7 @@ describe('build_sim tool', () => {
'platform=iOS Simulator,name=iPhone 16,OS=latest',
'build',
]);
expect(callHistory[0].logPrefix).toBe('iOS Simulator Build');
expect(callHistory[1].logPrefix).toBe('iOS Simulator Build');
});
});

Expand Down
Loading