docs: clarify agent-device binary resolution#511
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 592e591da5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ```bash | ||
| zsh -lic 'command -v agent-device' | ||
| ``` |
There was a problem hiding this comment.
Permit the new dogfood fallback command
When Claude Code enforces this skill's allowed-tools, the newly documented recovery path cannot run: line 4 still only allows Bash(agent-device:*) and Bash(npx agent-device:*), so zsh -lic 'command -v agent-device' (and any returned absolute binary path) is blocked in the exact scenario where agent-device is not on PATH. Please either allow this resolver/absolute-path invocation or avoid requiring it inside the restricted dogfood skill.
Useful? React with 👍 / 👎.
| ```bash | ||
| zsh -lic 'command -v agent-device' | ||
| ``` |
There was a problem hiding this comment.
Resolve the actual login shell instead of zsh
This guidance says to resolve the user's login shell, but the command unconditionally runs zsh; on Linux agents, bash/fish users, or machines without zsh, it either fails or reads the wrong shell startup files, so a valid global npm install can still be missed. Use the user's actual login shell (or clearly scope this to zsh/macOS and provide a portable alternative) so the documented fallback works outside zsh environments.
Useful? React with 👍 / 👎.
|
1890255 to
2751f6f
Compare
2751f6f to
7ecd2bf
Compare
Summary
Clarify agent-device CLI resolution for agent shells that do not inherit the user global npm install environment.
Replace unattended @latest npx examples with exact-version and trusted-install guidance.
Remove the standalone react-devtools skill; React DevTools routing now stays in agent-device help.
Touched files: 7.
Validation