Skip to content

docs: clarify agent-device binary resolution#511

Merged
thymikee merged 1 commit into
mainfrom
docs/agent-cli-path-fallback
May 13, 2026
Merged

docs: clarify agent-device binary resolution#511
thymikee merged 1 commit into
mainfrom
docs/agent-cli-path-fallback

Conversation

@thymikee
Copy link
Copy Markdown
Member

@thymikee thymikee commented May 13, 2026

Summary

Clarify agent-device CLI resolution for agent shells that do not inherit the user global npm install environment.
Replace unattended @latest npx examples with exact-version and trusted-install guidance.
Remove the standalone react-devtools skill; React DevTools routing now stays in agent-device help.
Touched files: 7.

Validation

  • zsh -lic 'pnpm install --frozen-lockfile'
  • zsh -lic 'pnpm format'
  • zsh -lic 'pnpm typecheck'
  • git diff --check

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 592e591da5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread skills/dogfood/SKILL.md Outdated
Comment on lines +18 to +20
```bash
zsh -lic 'command -v agent-device'
```
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Permit the new dogfood fallback command

When Claude Code enforces this skill's allowed-tools, the newly documented recovery path cannot run: line 4 still only allows Bash(agent-device:*) and Bash(npx agent-device:*), so zsh -lic 'command -v agent-device' (and any returned absolute binary path) is blocked in the exact scenario where agent-device is not on PATH. Please either allow this resolver/absolute-path invocation or avoid requiring it inside the restricted dogfood skill.

Useful? React with 👍 / 👎.

Comment on lines +28 to +30
```bash
zsh -lic 'command -v agent-device'
```
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Resolve the actual login shell instead of zsh

This guidance says to resolve the user's login shell, but the command unconditionally runs zsh; on Linux agents, bash/fish users, or machines without zsh, it either fails or reads the wrong shell startup files, so a valid global npm install can still be missed. Use the user's actual login shell (or clearly scope this to zsh/macOS and provide a portable alternative) so the documented fallback works outside zsh environments.

Useful? React with 👍 / 👎.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://callstackincubator.github.io/agent-device/pr-preview/pr-511/

Built to branch gh-pages at 2026-05-13 12:41 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@thymikee thymikee force-pushed the docs/agent-cli-path-fallback branch 5 times, most recently from 1890255 to 2751f6f Compare May 13, 2026 12:27
@thymikee thymikee force-pushed the docs/agent-cli-path-fallback branch from 2751f6f to 7ecd2bf Compare May 13, 2026 12:40
@thymikee thymikee merged commit 517b519 into main May 13, 2026
18 checks passed
@thymikee thymikee deleted the docs/agent-cli-path-fallback branch May 13, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant