-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: react-native-reanimated as peer dependency #4912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v6
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| module.exports = { | ||
| presets: ['module:@react-native/babel-preset'], | ||
| plugins: ['react-native-worklets/plugin'], | ||
| }; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| require('react-native-reanimated').setUpTests(); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I suggest converting to ESM with a named import so this file matches |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -96,7 +96,9 @@ | |
| "react-dom": "18.3.1", | ||
| "react-native": "0.82.1", | ||
| "react-native-builder-bob": "^0.21.3", | ||
| "react-native-reanimated": "^4.3.0", | ||
| "react-native-safe-area-context": "5.5.2", | ||
| "react-native-worklets": "^0.8.1", | ||
| "react-test-renderer": "19.1.1", | ||
| "release-it": "^13.4.0", | ||
| "rimraf": "^3.0.2", | ||
|
|
@@ -105,7 +107,9 @@ | |
| "peerDependencies": { | ||
| "react": "*", | ||
| "react-native": "*", | ||
| "react-native-safe-area-context": "*" | ||
| "react-native-reanimated": ">=4.3.0", | ||
| "react-native-safe-area-context": "*", | ||
| "react-native-worklets": ">=0.8.1" | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just a comment, not necessarily requesting changes as I'm not sure about best practices for |
||
| }, | ||
| "husky": { | ||
| "hooks": { | ||
|
|
@@ -119,6 +123,7 @@ | |
| "<rootDir>/testSetup.js" | ||
| ], | ||
| "setupFilesAfterEnv": [ | ||
| "<rootDir>/jestSetupAfterEnv.js", | ||
| "@testing-library/jest-native/extend-expect" | ||
| ], | ||
| "cacheDirectory": "./cache/jest", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,10 @@ jest.useFakeTimers(); | |
|
|
||
| jest.mock('react-native-safe-area-context', () => mockSafeAreaContext); | ||
|
|
||
| jest.mock('react-native-worklets', () => | ||
| require('react-native-worklets/src/mock') | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I suggest |
||
| ); | ||
|
|
||
| jest.mock('@react-native-vector-icons/material-design-icons', () => { | ||
| const React = require('react'); | ||
| const { Text } = require('react-native'); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment from Claude: