feat: add Android native perf profiling#757
Open
thymikee wants to merge 2 commits into
Open
Conversation
|
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Android native profiling collectors under the consolidated
perffamily for #694.perf cpu profile start|stop|report --kind simpleperfandperf trace start|stop --kind perfettoacross command contracts, CLI grammar, daemon routing/projection, typed client metadata, MCP-facing input, and compact output.Refs #696
Refs #694
Touched files: 24.
Validation
Worker validation passed:
pnpm check:quick.pnpm build.pnpm check:unitoutside sandbox: 247 unit files, 2332 unit tests, 8 smoke tests.pnpm format.git diff --check.Android emulator E2E:
emulator-5554, Pixel 9 Pro XL API 37.com.justforfun.neoncity.perf-e2e-696.perf metricsandperf framessucceeded with compact JSON./private/tmp/agent-device-696-app.perfetto-traceat 5,392,410 bytes.perf_event_open; the command returned the intended actionable hint to use a debuggable/profileable app or system image that permits profiling.SkillGym case was added but not runnable in the sandbox because external runner approval was denied.
This PR is Android-only. iOS native profiling remains separate.