feat: add Apple xctrace perf profiling#755
Open
thymikee wants to merge 1 commit into
Open
Conversation
|
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Apple native xctrace collection under the consolidated
perffamily for #694.perf cpu profile start|stop|report --kind xctraceandperf trace start|stop --kind xctrace..tracecontents as artifacts only.Refs #697
Refs #694
Touched files: 23.
Validation
Worker validation passed:
pnpm typecheck.pnpm check:unit: 247 unit files, 2335 tests, 8 smoke tests.pnpm format.pnpm build.pnpm clean:daemon.git diff --check.iOS simulator E2E:
iPhone 17, UDIDEE00C210-642F-4AAD-B4DE-94892624F5A4.com.apple.mobilesafari, sessionxctrace697-final.perf metricssucceeded;perf framesreported the expected simulator support limitation.perf cpu profile start/stop/report --kind xctracesucceeded, wrote.tmp/xctrace697/final-profile.trace, and honored--outfor.tmp/xctrace697/final-profile.json.perf trace start --kind xctrace --template "Animation Hitches"started and produced a.tracebundle; stop surfaced Apple’s simulator limitation:Hitches is not supported on this platform.Physical iPhone
00008150-001849640CF8401Cwas visible and Safari opened, but baselineperf metricstimed out after the daemon 90s request budget before profile/trace verification could safely proceed. The worker cleaned the stale xctrace process afterward.SkillGym case was added but not runnable in the sandbox because external runner approval was denied.