docs: clarify bookerReopened and bookerReloaded are for prerendered modals#51
Draft
hariombalhara wants to merge 1 commit intomainfrom
Draft
docs: clarify bookerReopened and bookerReloaded are for prerendered modals#51hariombalhara wants to merge 1 commit intomainfrom
hariombalhara wants to merge 1 commit intomainfrom
Conversation
…odals Co-Authored-By: hariom@cal.com <hariombalhara@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the embed events documentation to clarify that
bookerReopenedandbookerReloadedevents are only applicable for prerendered modals that are now visible.This adds a single clarifying sentence to each event's description to help developers understand when these events will fire.
Review & Testing Checklist for Human
bookerReopenedandbookerReloadedevents truly only fire for prerendered modals that are now visible (not for non-prerendered modals)Notes