Open
Conversation
schlndh
force-pushed
the
fix-php85MysqlAttrConstant
branch
from
878f9c3 to
c4a4b2d
Compare
schlndh
force-pushed
the
fix-php85MysqlAttrConstant
branch
from
c4a4b2d to
7f6816e
Compare
|
+1 😄 - I recently ran into these as well. Having this merged would be nice. Many thanks for suggesting the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.4 introduced driver-specific PDO subclases (e.g.
\PDO\Mysql). PHP 8.5 deprecated\PDO::MYSQL_*(etc) constants.I'm using phinx with
mysql_attr_multi_statements: 0and on PHP 8.5 I getThis PR should fix it.
I checked the other drivers as well, and the only other one with similar functionality is the SqlServerAdapter. However, that one doesn't seem to have the a PDO subclass.