Open
Conversation
Member
|
Is there a test case we might be missing? |
Member
|
One suggestion: the current fix handles A simpler approach that handles all cases: 'breakpoint' => (int)($row['breakpoint'] ?? 0),This is also consistent with how |
Contributor
Author
|
Another approach that works is to pass the column type in the insertQuery. I am not sure if there is an easier way to do this. |
…t the migrations into the unified table.
e3d4558 to
8ac1f25
Compare
Contributor
Author
|
The pipelines for mariadb seem to be stuck |
Contributor
|
MariaDB needs the same fix from cakephp/cakephp#19273 as that action is broken |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix migrations upgrade with postgres which has native booleans.
Fixes: #1022