Skip to content

Conversation

Copy link

Copilot AI commented Jan 30, 2026

Addresses review feedback to add test coverage for the interaction between fieldMap and dot notation in Identity::get().

Changes

  • Enhanced Identity::get() - Now applies fieldMap to the first segment of dot-separated paths. When 'account' is mapped to 'user_account', get('account.role') correctly resolves to user_account.role.

  • Added testFieldMappingWithDotNotation() - Verifies mapped fields work with both direct access and nested dot notation, original field names remain accessible, and unmapped paths return null.

Example

$identity = new Identity($data, [
    'fieldMap' => ['account' => 'user_account'],
]);

// Both work correctly now
$identity->get('account');        // Returns user_account data
$identity->get('account.role');   // Returns user_account.role value

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits January 30, 2026 09:14
Co-authored-by: ADmad <142658+ADmad@users.noreply.github.com>
…s tests

Co-authored-by: ADmad <142658+ADmad@users.noreply.github.com>
Copy link
Author

Copilot AI commented Jan 30, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/PHPCSStandards/PHP_CodeSniffer/zipball/0525c73950de35ded110cffafb9892946d7771b5
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/PHPCSStandards/composer-installer/zipball/845eb62303d2ca9b289ef216356568ccc075ffd1
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/cakephp/cakephp-codesniffer/zipball/8c9481165b0f2819ac58894c9a7e5599a55ad678
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/cakephp/cakephp/zipball/ae91c0950fd1a4ee9b97b31a8db744721cdb9bd0
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/cakephp/chronos/zipball/1e417fdd4a3c6602b6c4634cf54aa9b065127fa2
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/composer/ca-bundle/zipball/961a5e4056dd2e4a2eedcac7576075947c28bf63
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/firebase/php-jwt/zipball/5645b43af647b6947daac1d0f659dd1fbe8d3b65
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/laminas/laminas-diactoros/zipball/60c182916b2749480895601649563970f3f12ec4
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/laminas/laminas-httphandlerREDACTED/zipball/181eaeeb838ad3d80fbbcfb0657a46bc212bbd4e
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/myclabs/DeepCopy/zipball/07d290f0c47959fd5eed98c95ee5602db07e0b6a
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/nikic/PHP-Parser/zipball/dca41cd15c2ac9d055ad70dbfd011130757d1f82
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/phar-io/manifest/zipball/54750ef60c58e43759730615a392c31c80e23176
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/phar-io/version/zipball/4f7fd7836c6f332bb2933569e566a0d6c4cbed74
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/php-fig/clock/zipball/e41a24703d4560fd0acb709162f73b8adfc3aa0d
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/php-fig/container/zipball/c71ecc56dfe541dbd90c5360474fbc405f8d5963
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/php-fig/http-client/zipball/bb5906edc1c324c9a05aa0873d40117941e5fa90
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/php-fig/http-factory/zipball/2b4765fddfe3b508ac62f829e852b1501d3f6e8a
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/php-fig/http-message/zipball/402d35bcb92c70c026d1a6a9883f06b2ead23d71
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/php-fig/http-server-handler/zipball/84c4fb66179be4caaf8e97bd239203245302e7d4
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/php-fig/http-server-middleware/zipball/c1481f747daaa6a0782775cd6a8c26a1bf4a3829
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/php-fig/log/zipball/f16e1d5863e37f8d8c2a01719f5b34baa2b714d3
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/php-fig/simple-cache/zipball/764e0b3939f5ca87cb904f570ef9be2d78a07865
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/phpstan/phpdoc-parser/zipball/a004701b11273a26cd7955a61d67a7f1e525a45a
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/sebastianbergmann/cli-parser/zipball/90f41072d220e5c40df6e8635f5dafba2d9d4d04
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/sebastianbergmann/comparator/zipball/6a7de5df2e094f9a80b40a522391a7e6022df5f6
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/sebastianbergmann/complexity/zipball/bad4316aba5303d0221f43f8cee37eb58d384bbb
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/sebastianbergmann/diff/zipball/7ab1ea946c012266ca32390913653d844ecd085f
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/sebastianbergmann/environment/zipball/24a711b5c916efc6d6e62aa65aa2ec98fef77f68
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/sebastianbergmann/exporter/zipball/016951ae10980765e4e7aee491eb288c64e505b7
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/sebastianbergmann/global-state/zipball/ef1377171613d09edd25b7816f05be8313f9115d
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/sebastianbergmann/lines-of-code/zipball/97ffee3bcfb5805568d6af7f0f893678fc076d2f
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/sebastianbergmann/object-enumerator/zipball/1effe8e9b8e068e9ae228e542d5d11b5d16db894
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/sebastianbergmann/object-reflector/zipball/4bfa827c969c98be1e527abd576533293c634f6a
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/sebastianbergmann/php-code-coverage/zipball/4a9739b51cbcb355f6e95659612f92e282a7077b
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/sebastianbergmann/php-file-iterator/zipball/961bc913d42fe24a257bfff826a5068079ac7782
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/sebastianbergmann/php-invoker/zipball/12b54e689b07a25a9b41e57736dfab6ec9ae5406
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/sebastianbergmann/php-text-template/zipball/e1367a453f0eda562eedb4f659e13aa900d66c53
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/sebastianbergmann/php-timer/zipball/f258ce36aa457f3aa3339f9ed4c81fc66dc8c2cc
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/sebastianbergmann/phpunit/zipball/37ddb96c14bfee10304825edbb7e66d341ec6889
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/sebastianbergmann/recursion-context/zipball/0b01998a7d5b1f122911a66bebcb8d46f0c82d8c
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/sebastianbergmann/type/zipball/e549163b9760b8f71f191651d22acf32d56d6d4d
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/sebastianbergmann/version/zipball/3e6ccf7657d4f0a59200564b08cead899313b53c
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/slevomat/coding-standard/zipball/29bdaee8b65e7ed2b8e702b01852edba8bae1769
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/staabm/side-effects-detector/zipball/d8334211a140ce329c13726d4a715adbddd0a163
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/v9CsZp /usr/bin/composer install --no-interaction (http block)
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/thephpleague/container/zipball/041c52d266763887fff2256fb5dc9392d808f8f3
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)
  • https://api.github.com/repos/theseer/tokenizer/zipball/7989e43bf381af0eac72e4f0ca5bcbfa81658be4
    • Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/RUhCY9 /usr/bin/composer install --no-interaction } gmann-environmengit (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update dot separated field names for Identity::get() usage Add fieldMap support for dot notation in Identity::get() Jan 30, 2026
Copilot AI requested a review from ADmad January 30, 2026 09:17
@ADmad ADmad closed this Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants