fix(waf) : handle waf log format#43
Open
adrien-goetz-wmx wants to merge 3 commits intocado-security:mainfrom
Open
fix(waf) : handle waf log format#43adrien-goetz-wmx wants to merge 3 commits intocado-security:mainfrom
adrien-goetz-wmx wants to merge 3 commits intocado-security:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#42
I add two options to fix 2 bugs I found when running the script.
N°1 :
--convert_dateI force conversion of from_date, end_date and last_modified variables using pytz
N°2:
--use_og_nameWhen deciding if file should be uncompressed, script looks for .gz extension in tmp_name file generated by tempfile and not in original bucket key