docs(ci-scope): revise spec + plan — namedInputs over implicitDependencies#505
Merged
Conversation
PR #503 surfaced that Nx 22.5.1 rejects file-path syntax in implicitDependencies entries (validates strictly as project names; errored: "implicitDependencies point to non-existent project(s)" on //path). The Nx-native mechanism for file-level affecting-deps is per-project namedInputs referenced by target inputs. Spec updates: - Header revision note documenting the discovery. - Replace "implicitDependencies — fallback paths become first-class" section with "namedInputs — fallback paths become first-class". - Concrete project.json example uses namedInputs.deploymentConfig with {workspaceRoot}/... paths, bound to target inputs. - Migration sequencing updated: PR 1 retroactively documented as "tags only (shipped)"; PR 2 includes the namedInputs migration. - Risk surface revised: namedInputs target-binding fragility (must reference in target inputs to take effect). - Acceptance criteria updated. The shim still targets ~50 LOC; the migration goal is unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
PR 1's Task 1 collapsed to a SHIPPED stub with archived tag-categorization rules in a <details> block. Adds Task 2.5 to PR 2: add namedInputs. deploymentConfig to apps/cockpit and apps/website project.json, reference in build target inputs, smoke-test that nx affected picks up vercel.cockpit.json changes correctly. Keeps Tasks 3-8 unchanged (shim rewrite, test migration, smoke, commit, drift guard) — those don't depend on the implicitDependencies vs namedInputs distinction beyond the smoke-test expectations. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs-only revision of the ci-scope thin-shim spec + plan after PR #503 surfaced that Nx 22.5.1 rejects `implicitDependencies: ["//path"]` syntax.
Why
PR #503 attempted to migrate fallback path rules (vercel.*.json, deploy scripts, capability-registry.ts) into project.json's `implicitDependencies` field. Nx 22.5.1 validates implicitDependencies as project names only:
29 CI jobs failed. The implicitDependencies portion was reverted within #503 (commit `bc77c105`); only the scope:* tags shipped.
What this PR does (docs only)
Why namedInputs (Option A from the brainstorm)
Alternatives considered + rejected: implicitDependencies with fake config projects (awkward); keep applyFallbackPathScope in ci-scope.mjs (shim grows to ~80 LOC instead of ~50).
Test plan
🤖 Generated with Claude Code