chore(recorders): consolidate per-cap record scripts to the generic recorder#496
Merged
Conversation
…ecorder Five per-cap record scripts removed in favor of scripts/record-aimock-cap.sh (shipped in PR #482). The generic recorder reads cap metadata from the capability registry and drives any normal LLM-call → tool_call → continuation flow: Deleted (5): - cockpit/chat/generative-ui/angular/e2e/scripts/record-c-generative-ui.sh - cockpit/chat/a2ui/angular/e2e/scripts/record-c-a2ui.sh - cockpit/chat/subagents/angular/e2e/scripts/record-c-subagents.sh - cockpit/langgraph/streaming/angular/e2e/scripts/record-streaming.py - cockpit/chat/tool-calls/angular/e2e/scripts/record-c-tool-calls.py The 2 Python recorders predated the shell pattern entirely; they hand-instantiated ChatOpenAI and saved responses directly, drifting from real cap behavior over time. The generic recorder runs the actual cap backend through aimock --record, giving authoritative captures. Kept (1) as documented special case: - cockpit/chat/interrupts/angular/e2e/scripts/record-c-interrupts.sh c-interrupts requires interrupt-resume handshake (interrupt() inside ToolNode pauses the run with status=interrupted; the client must POST command.resume to continue). The generic recorder doesn't drive that two-phase dance — it treats `interrupted` as terminal. Header block in the kept script now explains why it's the special case. Identified during the post-Task-#4 e2e audit (item #4). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes 5 per-cap record scripts (3 shell + 2 Python) in favor of the generic `scripts/record-aimock-cap.sh` shipped in PR #482. The generic recorder reads cap metadata from the capability registry and drives any normal LLM-call → tool_call → continuation flow.
Net: -683 LOC, +14 LOC (kept-script header comment).
Deleted (5)
The 2 Python recorders predated the shell pattern entirely; they hand-instantiated ChatOpenAI and saved responses directly, drifting from real cap behavior over time. The generic recorder runs the actual cap backend through `aimock --record`, giving authoritative captures.
Kept (1) — documented special case
c-interrupts requires the interrupt-resume handshake (interrupt() inside ToolNode pauses with status=interrupted; client must POST `command.resume`). The generic recorder treats `interrupted` as terminal and doesn't drive that two-phase dance. The script now has a header block explaining why it's the special case.
The `record` Nx target in `cockpit/chat/interrupts/angular/project.json` continues to point at this script.
Test plan
Identified during
Post-Task-#4 e2e audit, item #4.
🤖 Generated with Claude Code