Open
Conversation
add a props table that enumerates each prop that the Cartesian component can take.
Contributor
Author
|
that is of course unless you prefer to just merge them once they're written, component by component |
Member
|
This lgtm, it's a huge improvement because it wasn't even documented before : ). Do you mind keeping the js block as standard style? 💟 |
Contributor
Author
|
@johno oop yeah no problem, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add a props table to each component's docs.
as mentioned in #197
this is a WIP, I'll remove the [WIP] from the title when its' ready for review - just wanted to throw this out there to start the discussion. I'm sure there will be tweaks to language and presentation.