feat: Smart/Origin parcours 3 itinévert #2100

lgourdin · 2025-12-10T15:05:07Z

No description provided.

…tia requests

(cherry picked from commit bc12f10)

…area

…hen saving (issue 1789)

… is not the same as the day in parameters

…nctions for Itinevert routes

…cess waypoint of the route

…6_api

…rogress

codacy-production · 2025-12-10T15:05:55Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -2.54%	✅ 31.42%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`ff024b9`)	20391	18884	92.61%
Head commit (`c32e727`)	21261 (+870)	19149 (+265)	90.07% (-2.54%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#2100)	888	279	31.42%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

Nayor

Hello !

Merci pour le travail !

Quelques petites remarques concernant quelques commentaire en français qui traînent, des noqa et codes HTTP incorrect

Ma plus grosse interrogation concerne la réplication des filtres elastics, destinés à évoluer pour faire des recherches améliorées. Comment cela sera-t-il compatible avec ce système ?

Est-ce possible de rajouter des tests ? ☺

Nayor · 2025-12-10T21:14:34Z

c2corg_api/__init__.py

+    api_key = os.getenv("NAVITIA_API_KEY")
+    max_duration = int(max_distance_waypoint_to_stoparea / walking_speed)
+
+    # Augmenter le nombre d'arrêts récupérés pour avoir plus de choix (comme dans le bash)  # noqa: E501


Les commentaires devraient être en anglais, comme pour le reste du code

Nayor · 2025-12-10T21:20:44Z

c2corg_api/__init__.py


    if "places_nearby" not in places_data or not places_data["places_nearby"]:
-        log.warning(f"No Navitia stops found for the waypoint {waypoint_id}")
+        log.warning(f"No Navitia stops found for the waypoint {waypoint_id}; deleting previously registered stops")  # noqa: E501


Préférer l'utilisation de %s ou .format pour une meilleure homogénéité du code (les f-string ne sont utilisés nulle part ailleurs)

Est-ce vraiment un warning ? C'est plutôt un comportement normal qui ne nécessite pas d'attention particulière ? (dans ce cas, préférer un .info)

Nayor · 2025-12-10T21:22:07Z

c2corg_api/__init__.py

+        delete_waypoint_stopareas(connection, waypoint_id)
        return

    # --- NOUVEAU : Filtrage par diversité de transport (comme dans bash) ---


traduire en anglias

Nayor · 2025-12-10T21:22:43Z

c2corg_api/__init__.py

-        },
-    )
-
    log.warning(f"Selected {selected_count} stops out of {len(places_data['places_nearby'])} for waypoint {waypoint_id}")  # noqa: E501


idem: format + # noqa: E501

Nayor · 2025-12-10T21:23:09Z

c2corg_api/__init__.py

-
    log.warning(f"Selected {selected_count} stops out of {len(places_data['places_nearby'])} for waypoint {waypoint_id}")  # noqa: E501

+    log.warning("Deleting previously registered stops")


idem -> log.info

Nayor · 2025-12-10T22:44:07Z

c2corg_api/views/navitia.py

+        response = {}
+
+        if (source_coverage):
+            # Appel à l'API Navitia Journey with coverage


Nayor · 2025-12-10T22:45:02Z

c2corg_api/views/navitia.py

+            # no_origin -> public transport not reachable from origin
+            # these do not count as proper errors,
+            # more like the wp is just not reachable
+            raise HTTPInternalServerError(response.json()['error'])


idem qu'au dessus ; mettre la gestion des erreurs dans une fonction commune ?

Nayor · 2025-12-10T22:45:17Z

c2corg_api/views/navitia.py

+        elif not response.ok:
+            raise HTTPInternalServerError(f'Navitia API error: {response.status_code}')  # noqa: E501
+        else:
+            # Retour des données JSON


commentaire inutile, et en français

Nayor · 2025-12-10T22:45:29Z

c2corg_api/views/navitia.py

+            'Timeout when calling the Navitia API')
+    except requests.exceptions.RequestException as e:
+        raise HTTPInternalServerError(f'{str(e)}')
+    except Exception as e:


Nayor · 2025-12-10T22:46:50Z

c2corg_api/views/navitia.py

+
+    try:
+        # Récupération de la clé API depuis les variables d'environnement
+        api_key = os.getenv('NAVITIA_API_KEY')


c'est le seul endroit du code où on récupère un paramètre comme ça ; pourquoi ne pas avoir fait comme ailleurs ?

lgourdin and others added 30 commits July 28, 2025 16:11

[CI] add CI pipeline as in github

b2d3301

[CI] Update CI after reverting deploy method in 752b2ea

24c84bb

[hotfix] add distincts scripts and change sqlalchemy events

0dd9ad6

[CI] source env for CI

905fa55

[fix] support updating TC when waypoint is modified and optimize navi…

b11143b

…tia requests

[scripts] make distinct navitia scripts executable

288e183

[GHCI] source env file before launching pytest

1d0480f

(cherry picked from commit bc12f10)

[chore] replace deprecated log.warn by log.warning

fbaf190

[fix] delete existing stopareas for waypoint if moved in an unserved …

b6caaa4

…area

[fix] formatting error in log string that was triggering 500 errors w…

6a88e18

…hen saving (issue 1789)

[chore] fix linting issues

3a540a1

[CI] run test script with set -e

8233f1d

[new feature] add reachable routes route

bb40e9e

[new feature] add reachable waypoints route

830581a

[new feature] add coverage table

ddb2f03

[new feature] add script to retrieve and insert coverages

bcb9a97

[fix] fixed a bug when trying to insert doc that is not a waypoint

e28025a

[new feature] added routes to get journey/isochrone reachable doc

94e05a3

[fix] add q=title filter in reachable doc routes

eb86874

[fix] make sure waypoints are not reachable if journeys departure day…

cfa6f73

… is not the same as the day in parameters

[refactor] organization + documentation : factorization and helper fu…

5f13610

…nctions for Itinevert routes

[fix] fix issue when filtering with several areas

479e003

[new feature] added route to get coverage for area / area in isochrone

2a1a847

[fix] fixed a bug where bbox applied to routes was not done on the ac…

2bd8db5

…cess waypoint of the route

Merge branch 'gp/dev'

72df94c

[lint] flake8 linting

4950c16

[CI] don't create dir if exists

8a55a1a

[CI] clean after test and debug comment

9054d05

Merge branch 'main' of https://git.smart-origin.com/SmartOrigin/c2c_v…

971fea1

…6_api

[fix] fix CI

c67b0b3

gerome.perrin and others added 13 commits December 3, 2025 14:37

[fix] Fix CI

e2b423e

[cleanup] remove S/O files before merging with upstream

10057e6

[fix] fix #1834 : durations filter wasn't working

3bb8456

[improve] add range filter to reduce time of computation

3b999d3

[fix] fix title query for waypoints in Iitnévert

0ba34c3

[fix] fix langs filter not working

3d6d24c

[fix] fixed incorrect join with area association

7dd7b2b

[fix] fix title filter when no other filters

90bb53d

[fix] fix lang filter

37e245d

[clean] remove debug log

7af8240

[new feature] add job handling for journey queries to monitor their p…

499b96b

…rogress

[lint] fix linter -> func names in lower case

53ff11f

[fix] fix search doc missing for coverage

2f5d6cb

Merge branch 'master' into smart-origin/revue_parcours_3

c32e727

Nayor requested changes Dec 10, 2025

View reviewed changes


		log.warning(f"Selected {selected_count} stops out of {len(places_data['places_nearby'])} for waypoint {waypoint_id}") # noqa: E501

		log.warning("Deleting previously registered stops")

Uh oh!

feat: Smart/Origin parcours 3 itinévert #2100

Are you sure you want to change the base?

feat: Smart/Origin parcours 3 itinévert #2100

Uh oh!

Conversation

lgourdin commented Dec 10, 2025

Uh oh!

codacy-production bot commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage summary from Codacy

Uh oh!

Nayor left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Nayor Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codacy-production bot commented Dec 10, 2025 •

edited

Loading

Nayor left a comment •

edited

Loading

Nayor Dec 10, 2025 •

edited

Loading