Skip to content

Conversation

@TerrorJack
Copy link
Contributor

No description provided.

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

// Proposals that we should add support for.
reference_types: self
.wasm_reference_types
let mut features = WasmFeatures::WASM2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you verify that this matches the feature set we had before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/bytecodealliance/wasm-tools/blob/v1.228.0/crates/wasmparser/src/features.rs#L278 it is. I've also enabled tail-call and extended-const since they should be safe for wizer, but if you prefer I can add options to make it possible to disable these two

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TerrorJack
Copy link
Contributor Author

CI passed; should be good to land unless there's something else needs fixing, cc @fitzgen

@fitzgen fitzgen merged commit fdea36d into bytecodealliance:main Apr 10, 2025
17 checks passed
alexcrichton pushed a commit to alexcrichton/wizer that referenced this pull request Oct 8, 2025
alexcrichton pushed a commit to alexcrichton/wizer that referenced this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants