-
Notifications
You must be signed in to change notification settings - Fork 65
Bump dependencies #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies #132
Conversation
fitzgen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
| // Proposals that we should add support for. | ||
| reference_types: self | ||
| .wasm_reference_types | ||
| let mut features = WasmFeatures::WASM2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you verify that this matches the feature set we had before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See https://github.com/bytecodealliance/wasm-tools/blob/v1.228.0/crates/wasmparser/src/features.rs#L278 it is. I've also enabled tail-call and extended-const since they should be safe for wizer, but if you prefer I can add options to make it possible to disable these two
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine
fitzgen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
CI passed; should be good to land unless there's something else needs fixing, cc @fitzgen |
No description provided.