Further refine behavior of large 1-byte-page memories#12976
Merged
fitzgen merged 1 commit intobytecodealliance:mainfrom Apr 6, 2026
Merged
Further refine behavior of large 1-byte-page memories#12976fitzgen merged 1 commit intobytecodealliance:mainfrom
fitzgen merged 1 commit intobytecodealliance:mainfrom
Conversation
This commit adjust the behavior of bytecodealliance#12884 to return -1 from `memory.grow` instead of trapping when the growth would exceed the maximal allowable size of memory. This fixes a fuzz-bug which had an unexpected trap and upon further reflection this feels more accurate for what custom-page-sizes can do. With a 1-byte-page memories can grow to 4GiB-2 because that means that -1 always means "growth failed".
fitzgen
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adjust the behavior of #12884 to return -1 from
memory.growinstead of trapping when the growth would exceed the maximal allowable size of memory. This fixes a fuzz-bug which had an unexpected trap and upon further reflection this feels more accurate for what custom-page-sizes can do. With a 1-byte-page memories can grow to 4GiB-2 because that means that -1 always means "growth failed".