Skip to content

Adjust depth calculation of map<K, V> type #12760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cfallin merged 1 commit into from
Mar 15, 2026
Merged

Adjust depth calculation of map<K, V> type #12760

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/environ/src/component/types_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1228,8 +1228,8 @@ impl TypeInformation {
*self = TypeInformation::string();
let key_info = types.type_information(&ty.key);
let value_info = types.type_information(&ty.value);
// Depth is max of key/value depths, plus 1 for tuple, plus 1 for list
self.depth = key_info.depth.max(value_info.depth) + 2;
// Depth is max of key/value depths, plus 1 for the extra map layer.
self.depth = key_info.depth.max(value_info.depth) + 1;
self.has_borrow = key_info.has_borrow || value_info.has_borrow;
}
}
Loading