Fix a stacks fuzzer regression#12755
Open
alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
Open
Fix a stacks fuzzer regression#12755alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
stacks fuzzer regression#12755alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
This commit fixes an accidental mistake from bytecodealliance#12542 where when the `limit` of stack frames for the fuzzer to capture is `None` then it meant that backtraces were never captured. This updates the assertion logic to handle a missing `WasmBacktrace` and the case that `stacks.limit` is `None`.
github-actions
bot
added
the
fuzzing
Subscribe to Label Actioncc @fitzgen DetailsThis issue or pull request has been labeled: "fuzzing"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an accidental mistake from #12542 where when the
limitof stack frames for the fuzzer to capture isNonethen it meant that backtraces were never captured. This updates the assertion logic to handle a missingWasmBacktraceand the case thatstacks.limitisNone.