Lift/lower refactors inspired by map<K, V>#12753
Open
alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
Open
Lift/lower refactors inspired by map<K, V>#12753alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
map<K, V>#12753alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
In reading over bytecodealliance#12216 I found a few related but also somewhat orthogonal refactors that I wanted to implement, and thus this commit. Changes here are: * Handling pointer pairs for lists/maps/strings is now more uniform with a single set of functions doing the lift/lower to flat/memory. Less "FIXME 4311" spread throughout effectively. * Conditional defines and organization of the `HashMap`-related impls were tweaked, for example impls on `HashMap` are now unconditional as well as `TryHashMap`. Some internals were refactored to in theory reduce complexity, but this is also subjective. * Lifting a `map<K, V>` now consumes fuel, a recent change, to ensure that resource exhaustion in the host is limited.
github-actions
bot
added
the
wasmtime:api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In reading over #12216 I found a few related but also somewhat orthogonal refactors that I wanted to implement, and thus this commit. Changes here are:
Handling pointer pairs for lists/maps/strings is now more uniform with a single set of functions doing the lift/lower to flat/memory. Less "FIXME 4311" spread throughout effectively.
Conditional defines and organization of the
HashMap-related impls were tweaked, for example impls onHashMapare now unconditional as well asTryHashMap. Some internals were refactored to in theory reduce complexity, but this is also subjective.Lifting a
map<K, V>now consumes fuel, a recent change, to ensure that resource exhaustion in the host is limited.