chore: avoid panic when parsing --dir argument#12604
Closed
Ocheretovich wants to merge 1 commit intobytecodealliance:mainfrom
Closed
chore: avoid panic when parsing --dir argument#12604Ocheretovich wants to merge 1 commit intobytecodealliance:mainfrom
Ocheretovich wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
Signed-off-by: Ocheretovich Oksana <ocheretovich@gmail.com>
pchickey
requested changes
Feb 17, 2026
Contributor
pchickey
left a comment
There was a problem hiding this comment.
Did you find an input that can create this panic? From the docs of split
https://doc.rust-lang.org/std/primitive.str.html#method.split
Returns an iterator over substrings of this string slice, separated by characters matched by a pattern.
...
If there are no matches the full string slice is returned as the only item in the iterator.
by my reading, the iterator given by split will always contain at least one value, therefore the first call to next will always give Some.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid potential panic when parsing --dir argument by returning a proper error instead of unwrapping