Update libm and simplify where it's used #12425
Open
+4
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cranelift
alexcrichton
approved these changes
Jan 24, 2026
| /// Returns the nearest integer to `self`. Rounds half-way cases to the number | ||
| /// with an even least significant digit. | ||
| pub fn round_ties_even(self) -> Self { | ||
| // TODO: when libm v0.2.16 is published line below can be used instead |
Member
There was a problem hiding this comment.
I think this comment line can be deleted too now, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change since the new libm version was released, and the trait based implementation can be simplified