async/stream/future plumbing for wasmtime-environ#10047
Merged
dicej merged 2 commits intobytecodealliance:mainfrom Jan 22, 2025
Merged
async/stream/future plumbing for wasmtime-environ#10047dicej merged 2 commits intobytecodealliance:mainfrom
dicej merged 2 commits intobytecodealliance:mainfrom
Conversation
Contributor
Author
|
@alexcrichton note all the new fields I've added to |
github-actions
bot
added
the
wasmtime:api
alexcrichton
approved these changes
Jan 21, 2025
I've split this out of bytecodealliance#9582 to make review easier. This patch includes the plumbing needed to route async/stream/future/error-context data from `wit-parser`, through the various layers of `wasmtime-environ`, and on to `wasmtime-cranelift` and `wasmtime`. The `wasmtime::runtime`, `wasmtime_environ::fact`, and `wasmtime_cranelift::compiler::component` modules only contain `todo!()` stubs to begin with; I'll flesh those out in later PRs. Signed-off-by: Joel Dice <joel.dice@fermyon.com> remove debugging code Signed-off-by: Joel Dice <joel.dice@fermyon.com> revert comment formatting change in trap_encoding.rs Signed-off-by: Joel Dice <joel.dice@fermyon.com> deduplicate code in inline.rs Signed-off-by: Joel Dice <joel.dice@fermyon.com> remove `ComponentTypesBuilder::error_context_type` This was just an alias for `error_context_table_type`, which I've made public. Signed-off-by: Joel Dice <joel.dice@fermyon.com> defer `VMComponentOffsets` changes to a future PR Signed-off-by: Joel Dice <joel.dice@fermyon.com>
dicej
force-pushed
the
wasmtime-environ-async-plumbing
branch
from
e1c4ff0 to
8f4d991
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've split this out of #9582 to make review easier.
This patch includes the plumbing needed to route
async/stream/future/error-context data from
wit-parser, through the various layers ofwasmtime-environ, and on towasmtime-craneliftandwasmtime. Thewasmtime::runtime,wasmtime_environ::fact, andwasmtime_cranelift::compiler::componentmodules only containtodo!()stubs to begin with; I'll flesh those out in later PRs.