wasm-wave: catch error in UntypedFuncCall::to_wasm_params#2528
Merged
Conversation
pchickey
force-pushed
the
pch/wave_error_check
branch
from
57c5677 to
2951700
Compare
alexcrichton
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug in
wasm_wave::UntypedFuncCall::to_wasm_params: when to_wasm_params was called on a function which was parsed with no arguments, the length of the types is never checked to compare it to the arguments.This change required the iterator accepted by that function to be an ExactSizeIterator so that the length may be checked, and catches the case where an empty list of parameters is applied to a non-empty list of types.