Skip to content

Redefine a minimal bundle to have only one LiveRange. #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cfallin merged 1 commit into from
Apr 7, 2025
Merged

Redefine a minimal bundle to have only one LiveRange. #214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/ion/process.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,7 @@ impl<'a, F: Function> Env<'a, F> {
let mut fixed = false;
let mut fixed_def = false;
let bundledata = &self.ctx.bundles[bundle];
let num_ranges = bundledata.ranges.len();
let first_range = bundledata.ranges[0].index;
let first_range_data = &self.ctx.ranges[first_range];

Expand All @@ -277,7 +278,7 @@ impl<'a, F: Function> Env<'a, F> {
trace!(" -> no vreg; minimal and fixed");
minimal = true;
fixed = true;
} else {
} else if num_ranges == 1 {
for u in &first_range_data.uses {
trace!(" -> use: {:?}", u);
if let OperandConstraint::FixedReg(_) = u.operand.constraint() {
Expand All @@ -291,15 +292,18 @@ impl<'a, F: Function> Env<'a, F> {
break;
}
}
// Minimal if the range covers only one instruction. Note
// that it could cover just one ProgPoint,
// Minimal if there is only one LR and the ProgPoint range
// covers only one instruction. Note that it could cover
// just one ProgPoint,
// i.e. X.Before..X.After, or two ProgPoints,
// i.e. X.Before..X+1.Before.
trace!(" -> first range has range {:?}", first_range_data.range);
let bundle_start = self.ctx.bundles[bundle].ranges.first().unwrap().range.from;
let bundle_end = self.ctx.bundles[bundle].ranges.last().unwrap().range.to;
minimal = bundle_start.inst() == bundle_end.prev().inst();
trace!(" -> minimal: {}", minimal);
} else {
minimal = false;
}

let spill_weight = if minimal {
Expand Down