This repository was archived by the owner on Mar 24, 2022. It is now read-only.
Merged
Conversation
Linux is not strict on this, but e.g. FreeBSD is.
On FreeBSD/amd64, SIGSTKSZ == MINSIGSTKSZ(4 * 512) + 32768 == 34816. This is not a multiple of the 4k page size, which is required, so use the custom size. Plus, rewrite the choice using cfg_if, as manual cfgs are getting unwieldy.
Finally includes FreeBSD/amd64 mcontext/ucontext
Closed
acfoltzer
approved these changes
Aug 18, 2020
Contributor
acfoltzer
left a comment
acfoltzer
left a comment
There was a problem hiding this comment.
Thanks to you and @myfreeweb 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is PR #419 rebased on
mainand pushed to this repo - I think that circleci is broken on forks, so trying a local push to get it to pass.