This repository was archived by the owner on Mar 24, 2022. It is now read-only.
add option to report timing, as well as reporting time taken to output#381
Open
add option to report timing, as well as reporting time taken to output#381
Conversation
iximeow
commented
Dec 19, 2019
iximeow
commented
Dec 21, 2019
| let cranelift_time_text = cranelift_codegen::timing::take_current().to_string(); | ||
| // skip the header text from Cranelift's `Display`, then take until we hit the end (also | ||
| // "======= ======= ==...") | ||
| for pass in cranelift_time_text |
Contributor
Author
There was a problem hiding this comment.
this is some real nastyness but I don't see a way to record duration/times without stringifying and splitting. I'll follow up in cranelift and see about exposing this in a more friendly form.
iximeow
commented
Dec 21, 2019
| ErrorStyle::Json => { | ||
| let errs: Option<Vec<SerializedLucetcError>> = | ||
| compile_result.err().map(|err| vec![err.into()]); | ||
| let result = json!({ |
Contributor
Author
There was a problem hiding this comment.
this is a breaking change in output format for anyone mechanically processing lucetc output today, but the array of errors was probably a bit too rigid anyway?
Contributor
|
This PR was closed as a byproduct of deleting the branch named |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
--report-timeswhich makes for nice breakdowns vialucetc --report-times slow_to_compile.watlike:or in json (
../target/debug/lucetc tests/wasm/arith.wat --report-times --error-style json):