fix(p3-shim): complete HTTP transmit futures from worker#1504
Merged
Conversation
andreiltd
force-pushed
the
fix/http-semantics
branch
3 times, most recently
from
5fefd42 to
4e7b87f
Compare
Send http request bodies and trailers concurrently with response handling, and settle the request transmit future only after upload completion or failure.
andreiltd
force-pushed
the
fix/http-semantics
branch
from
4e7b87f to
a1b714e
Compare
andreiltd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes few fixes driven by upstream tests but most importantly it fixes sending http request bodies and trailers concurrently with response handling, and settle the request transmit future only after upload completion.