create binary symlinks with relative location#159
Open
UiP9AV6Y wants to merge 1 commit intobwplotka:mainfrom
Open
create binary symlinks with relative location#159UiP9AV6Y wants to merge 1 commit intobwplotka:mainfrom
UiP9AV6Y wants to merge 1 commit intobwplotka:mainfrom
Conversation
Owner
|
Nice! I like this change but it would be good to have a green CI on this, let's rebase once we fix main tests: #162 We could also add dedicated unit test so we don't break this invariant of portability of symlinks |
Owner
|
Can you also rebase? We fixed build. |
UiP9AV6Y
force-pushed
the
feature/relative_symlinks
branch
from
14f577d to
53c9b90
Compare
since the installed binary as well as the symlink reside in the same directory, relative paths should be safe to use without having to worry about crossing filesystem boundaries. closes bwplotka#158
UiP9AV6Y
force-pushed
the
feature/relative_symlinks
branch
from
53c9b90 to
9d18cdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since the installed binary as well as the symlink reside in the same directory, relative paths should be safe to use without having to worry about crossing filesystem boundaries.
closes #158